fix: resolve remaining design system type issues#422
Merged
ECWireless merged 1 commit intomainfrom Dec 12, 2025
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request resolves remaining TypeScript type issues with the design system by replacing shorthand CSS property names with their full equivalents and standardizing import ordering. The changes also add a TypeScript type checking script and improve error handling in one location.
Key changes:
- Replaced shorthand CSS properties (
pt,mr,mb,bc,pr) with full property names (paddingTop,marginRight,marginBottom,backgroundColor,paddingRight) across multiple components - Alphabetically sorted imports in several files for consistency
- Added a
typechecknpm script for running TypeScript checks without emitting files - Enhanced error logging in banner dismissal logic
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pages/_error.tsx | Replaced shorthand CSS properties (bc, pr, mr) with full property names |
| package.json | Added typecheck script for TypeScript validation |
| layouts/main.tsx | Alphabetically sorted imports and improved error logging in banner dismissal |
| components/URLVerificationBanner/index.tsx | Moved React import after design-system imports for consistency |
| components/Hamburger/index.tsx | Replaced shorthand CSS properties (mr, mb, bc) with full names |
| components/Drawer/index.tsx | Alphabetically sorted local component imports |
| components/DelegatingWidget/Footnote.tsx | Replaced pt with paddingTop |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Summary
This pull request primarily refactors styling code to use more explicit CSS property names in several components, improves import ordering for consistency, and adds a new script for TypeScript type checking. There are also minor error handling and code organization improvements.
Styling refactor:
pt,mr,mb,bc,pr) with their full equivalents (e.g.,paddingTop,marginRight,marginBottom,backgroundColor,paddingRight) inFootnote.tsx,Hamburger/index.tsx, and_error.tsxfor clarity and maintainability. [1] [2] [3]Import ordering and organization:
Drawer/index.tsx,URLVerificationBanner/index.tsx, andmain.tsxto maintain a consistent and logical structure, movingLogoandReactimports to appropriate positions. [1] [2] [3] [4] [5]Error handling improvements:
main.tsxto log errors to the console instead of silently catching them, aiding debugging.Tooling enhancements:
typecheckscript topackage.jsonfor running TypeScript checks without emitting files, improving developer workflow.