Skip to content

fix: apply top padding to search bar dialog#550

Merged
ECWireless merged 3 commits intomainfrom
fix/search-close-overlap
Feb 13, 2026
Merged

fix: apply top padding to search bar dialog#550
ECWireless merged 3 commits intomainfrom
fix/search-close-overlap

Conversation

@rickstaa
Copy link
Member

Description

Ensure that the close icon does not overlap with the input field.

Type of Change

  • feat: New feature
  • fix: Bug fix
  • docs: Documentation update
  • style: Code style/formatting changes (no logic changes)
  • refactor: Code refactoring (no behavior change)
  • perf: Performance improvement
  • test: Adding or updating tests
  • build: Build system or dependency changes
  • ci: CI/CD changes
  • chore: Other changes

Related Issue(s)

Related: #497
Closes: #494

Changes Made

  • Added top padding to search dialog.

Testing

  • Tested locally
  • Added/updated tests
  • All tests passing

How to test (optional unless test is not trivial)

Impact / Risk

Risk level: Low
Impacted areas: UI
User impact: Easier interaction with search dialog.
Rollback plan: Revert

Screenshots / Recordings (if applicable)

Before

image image

After

image image

Additional Notes

Copilot AI review requested due to automatic review settings February 11, 2026 03:24
@rickstaa rickstaa requested a review from ECWireless as a code owner February 11, 2026 03:24
@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
explorer-arbitrum-one Ready Ready Preview, Comment Feb 13, 2026 4:17pm

Request Review

Ensure that the close icon does not overlap with the input field.

Co-authored-by: Sebastian <115311276+Roaring30s@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a UI overlap in the Search dialog by adding additional top spacing so the close icon doesn’t collide with the search input.

Changes:

  • Adjusted DialogContent styling to reposition the close button within the dialog.
  • Added top spacing to the Search dialog content to prevent overlap with the close icon.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Feb 11, 2026

@rickstaa I've opened a new pull request, #551, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI commented Feb 11, 2026

@rickstaa I've opened a new pull request, #552, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rickstaa <17570430+rickstaa@users.noreply.github.com>
@ECWireless
Copy link
Collaborator

For whatever reason, this doesn't seem to look like the "after" screenshots for me:

Screenshot 2026-02-12 at 4 28 05 PM

@rickstaa happy to take over this PR, since I know you're still OOO

@rickstaa
Copy link
Member Author

For whatever reason, this doesn't seem to look like the "after" screenshots for me:

Screenshot 2026-02-12 at 4 28 05 PM @rickstaa happy to take over this PR, since I know you're still OOO

Ah maybe the copilot pull request broke things. Thanks!

…ent (#552)

* Initial plan

* fix: replace brittle :last-child selector with DialogClose component

Co-authored-by: rickstaa <17570430+rickstaa@users.noreply.github.com>

* chore: add package-lock.json to .gitignore

Co-authored-by: rickstaa <17570430+rickstaa@users.noreply.github.com>

* Update progress: all checks passed

Co-authored-by: rickstaa <17570430+rickstaa@users.noreply.github.com>

* fix: remove duplicate IconButton

* fix: remove unnecessary DialogClose

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rickstaa <17570430+rickstaa@users.noreply.github.com>
Co-authored-by: ECWireless <elliott@coopallc.com>
Co-authored-by: ECWireless <40322776+ECWireless@users.noreply.github.com>
@ECWireless ECWireless merged commit 4a7ca3c into main Feb 13, 2026
8 checks passed
@ECWireless ECWireless deleted the fix/search-close-overlap branch February 13, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exit Icon Should Be Outside Search Bar

3 participants