chore(deps): resolve npm audit findings#138
Conversation
Pin minimatch to patched versions via npm overrides, upgrade tooling deps (vitest/vite, rollup commonjs), and bump @testing-library/react for React 19 compatibility. Regenerates package-lock.json so installs are consistent and npm audit is clean. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughAdds a root-level npm Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/plugin-publisher/backend/package.json`:
- Line 33: The package.json now depends on "vitest": "^4.0.18" which skips major
versions and will break tests; either pin Vitest to a compatible v3.x range or
add a vitest.config.ts to explicitly handle v4 breaking changes: replace
deprecated pool keys (use maxWorkers instead of maxThreads/maxForks), restore
previous test discovery defaults, adapt coverage settings and reporters, and
confirm hook execution order; update package.json's "vitest" version or
add/commit a vitest.config.ts that sets maxWorkers and the legacy-like
discovery/coverage/reporters options so the test suite continues to run as
before.
In `@plugins/plugin-publisher/frontend/package.json`:
- Line 32: The dependency `@vitejs/plugin-react` in package.json must be bumped to
^4.3.4 or higher for Vite 6 compatibility; open
plugins/plugin-publisher/frontend/package.json, locate the `@vitejs/plugin-react`
entry and update its version specifier to ^4.3.4 (or a newer compatible patch)
and then run your package manager (npm/yarn/pnpm) to reinstall and lock the
updated version so Vite 6 is supported.
In `@services/infrastructure-svc/package.json`:
- Line 31: Remove the extraneous DefinitelyTyped package "@types/tar" from
package.json dependencies/devDependencies to avoid conflicts with tar v7's
built-in types; locate the entry "@types/tar" in
services/infrastructure-svc/package.json and delete it, then run npm/yarn
install to update lockfile and verify TypeScript compiles using the bundled
types from the "tar" package.
- Add vitest v4 config for plugin-publisher backend tests. - Bump @vitejs/plugin-react for Vite 6 compatibility. - Drop @types/tar (tar@7 bundles types) and fix infra route handler returns so tsc passes. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
plugins/plugin-publisher/frontend/package.json (1)
15-32: Add explicitenginesfield for consistency with CI baseline.
The CI runs Node 20 (compatible with Vite 6), but the frontend package.json lacks anenginesdeclaration. Add"engines": {"node": "^20.0.0"}to align local development with the CI baseline and prevent accidental use of incompatible Node versions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/plugin-publisher/frontend/package.json` around lines 15 - 32, Add an explicit engines entry to the frontend package.json by adding an "engines" field with "node": "^20.0.0" so local dev matches CI's Node 20 baseline; update the root package.json object in plugins/plugin-publisher/frontend's package.json (the same file containing dependencies and devDependencies) to include "engines": {"node":"^20.0.0"} at top-level.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@services/infrastructure-svc/package.json`:
- Around line 17-34: Remove "semver" and "yaml" from the top-level
"dependencies" block in package.json and either delete them entirely or add them
to "devDependencies" (matching the style of existing dev entries) so they are
not shipped as runtime dependencies; ensure you leave "ws" in "dependencies"
since server.ts imports it and update package.json accordingly (remove
duplicate/version mismatches if any).
---
Nitpick comments:
In `@plugins/plugin-publisher/frontend/package.json`:
- Around line 15-32: Add an explicit engines entry to the frontend package.json
by adding an "engines" field with "node": "^20.0.0" so local dev matches CI's
Node 20 baseline; update the root package.json object in
plugins/plugin-publisher/frontend's package.json (the same file containing
dependencies and devDependencies) to include "engines": {"node":"^20.0.0"} at
top-level.
- Reintroduce 'semver' and 'yaml' as devDependencies in package.json. - Clean up package-lock.json to reflect the changes in dependencies.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@services/infrastructure-svc/package.json`:
- Around line 25-34: The package.json devDependencies currently list "vitest":
"^4.0.18" but omit the required Vite peer; update services/infrastructure-svc's
package.json devDependencies to include "vite": "^6.0.0" (or "^7.0.0" if you
prefer) alongside "vitest" so Vitest's peer dependency is satisfied, then run
your package manager to regenerate the lockfile (npm/yarn/pnpm) and verify tests
run; this change is centered on the devDependencies section where "vitest" is
declared.
- Updated package.json and package-lock.json to include Vite version 6.0.0 as a dependency for the infrastructure service.
Summary
minimatch.vite/esbuildchains (Vitest/Vite, Rollup commonjs).@testing-library/reactin@naap/plugin-sdkfor React 19 compatibility.package-lock.jsonfrom a clean install.Test plan
npm installnpm audit(expect 0 vulnerabilities)Made with Cursor
Summary by CodeRabbit