fix: address CodeRabbit review comments from PRs #41, #42, #43

[seanhanca]

Summary

Addresses all actionable review comments from CodeRabbit's reviews on the three recently merged PRs:

• sendgrid.ts: Normalize EmailRecipient objects in sendTemplate() (was only done in send()/sendHtml()); pass attachments through convertOptions() instead of silently dropping them
• client.ts: Unwrap data.comment in acceptAnswer() for consistent envelope handling
• Test cleanup: Move vi.useRealTimers() to afterEach() to prevent fake timer leaks across tests
• personalized/route.ts: Document the idempotent lazy-write design and add Cache-Control: no-store
• Capacity.tsx: Fix stale closure by removing selectedRequest from useCallback deps and using functional updater
• .coderabbit.yaml: Enable request_changes_workflow so future PRs are blocked when CodeRabbit finds issues

Test plan

• SDK type-checks clean (tsc --noEmit)
• All 88 web-next tests pass
• CodeRabbit reviews this PR (verifies new config)

Made with Cursor

Summary by CodeRabbit

• New Features

  • Email attachments are now supported in the SendGrid email integration.

• Bug Fixes

  • Fixed response parsing for accepted answers in the community feature.
  • Improved caching behavior for personalized plugins to prevent stale responses.

• Tests

  • Enhanced test cleanup to properly restore timers and prevent state leakage between tests.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
naap-platform	Ready	Preview, Comment	Feb 10, 2026 10:14pm

[coderabbitai]

Warning

Rate limit exceeded

@seanhanca has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

Improvements to PR review configuration, API caching behavior, test cleanup patterns, email attachment support, optimistic UI updates, and API response handling across configuration, infrastructure, testing, plugin SDKs, and plugin frontends.

Changes

Cohort / File(s)	Summary
PR Review Configuration .coderabbit.yaml	Enabled request_changes_workflow to actively block PRs until all comments are resolved, with descriptive comments explaining the behavior and alignment with branch protection rules.
API Caching and Documentation apps/web-next/src/app/api/v1/base/plugins/personalized/route.ts	Added documentation explaining lazy-install behavior for core plugins, and updated response handling to set Cache-Control: no-store headers to prevent stale caches.
Test Cleanup apps/web-next/src/hooks/__tests__/useDashboardQuery.test.ts, apps/web-next/src/hooks/__tests__/useJobFeedStream.test.ts	Standardized test timer cleanup by introducing afterEach hooks to restore real timers, preventing timer leakage across tests and removing in-test explicit timer restoration calls.
Email Attachment Support packages/plugin-sdk/src/integrations/email/sendgrid.ts	Extended SendGrid integration to support email attachments: added convertOptions attachment handling, new resolveEmail helper, updated sendTemplate and sendMail methods to normalize recipient values and include base64-encoded attachments in payloads.
Optimistic Update Refactoring plugins/capacity-planner/frontend/src/pages/Capacity.tsx	Refactored thumbs-up action optimistic update path to use functional updater pattern for selected request state, improving stale closure handling and removing explicit selectedRequest dependency.
API Response Parsing plugins/community/frontend/src/api/client.ts	Updated acceptAnswer method to unwrap response payload by preferring json.data.comment over json.data when available, improving envelope handling for API responses.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• fix: community reply crash due to missing envelope unwrapping #41: Overlaps with test timer fixes in hooks tests and SendGrid integration changes for email handling.
• feat(dashboard): add GraphQL provider for dashboard data #43: Directly related modification of SendGrid integration with attachment support building on prior convertOptions changes.
• feat(admin): configurable core plugins with auto-install #42: Shares code-level changes in personalized route endpoint and hooks test cleanup patterns.

Suggested labels

scope/sdk, scope/packages, plugin/community, plugin/capacity-planner, size/L

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main purpose of the changeset: addressing CodeRabbit review comments from three specific PRs.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/coderabbit-review-followups

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@plugins/capacity-planner/frontend/src/pages/Capacity.tsx`:
- Around line 214-241: handleThumbsUp reads selectedRequest from the closure for
the optimistic update which can be stale; change the optimistic selected-request
update to use the functional updater pattern like the rollback path so it never
reads selectedRequest directly from the closure. Specifically, replace the early
guard that inspects selectedRequest in handleThumbsUp with a call to
setSelectedRequest(prev => { if (!prev || prev.id !== request.id) return prev;
if (alreadyCommitted) return {...prev, softCommits: prev.softCommits.filter(sc
=> sc.userId !== user.id)}; return {...prev, softCommits: [...prev.softCommits,
{id: `sc-${Date.now()}`, userId: user.id, userName: user.name, timestamp: new
Date().toISOString()}]}; }); so the updater is driven only by prev and you can
keep the dependency array ([committedIds]) unchanged.