Conversation
* Moved the ErrorCallback type alias definition from __init__.py to base.py for better organization. * Updated imports in __init__.py to reflect the new location of ErrorCallback.
pschroedl
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change resolves a linter error "Module level import not at top of file" by moving the
ErrorCallbacktype from the__init__.pyfile to thebaseclass. This change improves code quality, generally types should not be defined in the init.Moving type declaration to the bottom of imports in
__init__.pycaused circular import errors when installed as editable, so refactoring was the best option