Skip to content

fix(x-go-type-override-on-ref): fix impl for go type override #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zdunecki merged 2 commits into from
Sep 30, 2025
Merged

fix(x-go-type-override-on-ref): fix impl for go type override #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dab3f4c
fix(x-go-type-override-on-ref): fix impl for go type override
zdunecki Sep 30, 2025
70f4608
Merge remote-tracking branch 'origin/livesession' into fix/x-go-type-…
zdunecki Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions internal/test/x-go/x-go-type/override_on_ref/Makefile
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion internal/test/x-go/x-go-type/override_on_ref/x_go_type_override_on_ref.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions pkg/codegen/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,19 @@ func GenerateGoSchema(sref *openapi3.SchemaRef, path []string) (Schema, error) {
return mergedSchema, nil
}

// AllOf is interesting, and useful. It's the union of a number of other
// schemas. A common usage is to create a union of an object with an ID,
// so that in a RESTful paradigm, the Create operation can return
// (object, id), so that other operations can refer to (id)
if schema.AllOf != nil {
mergedSchema, err := MergeSchemas(schema, path)
if err != nil {
return Schema{}, fmt.Errorf("error merging schemas: %w", err)
}
mergedSchema.OAPISchema = schema
return mergedSchema, nil
}

// Schema type and format, eg. string / binary
t := schema.Type
// Handle objects and empty schemas first as a special case
Expand Down