Skip to content

FOLLOW-UP: Document highlight coalescing behavior change (from PR #49) #52

@adnaan

Description

@adnaan

Context

This follow-up task was identified during the review of PR #49.

Source PR: #49
PR Title: feat: extend lvt-el: and lvt-fx: to support native DOM event triggers
Suggested by: @claude[bot] (2 reviews)

Task Description

PR #49 added a __lvtHighlighting reentrancy guard to applyFxEffect that changes existing implicit-trigger semantics: when a DOM update fires during an in-flight highlight animation, the re-highlight is now silently dropped instead of restarting the animation.

This is intentional (prevents stale originalBackground capture on overlapping triggers) and documented in code comments, but should be noted in the CHANGELOG or release notes so existing lvt-fx:highlight users are aware of the behavior change.

Original Comments

"The old handleHighlightDirectives had no guard — every DOM update re-triggered the flash. Now elements that fire on every DOM update will be rate-limited to one highlight at a time per element." — @claude[bot]


This issue was automatically created by prmonitor from PR review comments.

Metadata

Metadata

Assignees

No one assigned

    Labels

    follow-upFollow-up task from PR reviewfrom-reviewIssue originated from PR review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions