Skip to content

FOLLOW-UP: Confirm server behavior for unrecognized __navigate__ action (from PR #72) #76

@adnaan

Description

@adnaan

Context

This follow-up task was identified during the review of PR #72.

Source PR: #72
PR Title: feat: lvt-preserve attributes, navigate SPA nav, DOMParser script fix
Suggested by: @claude[bot]

Task Description

The CHANGELOG for PR #72 notes:

The __navigate__ in-band action is a no-op on server versions before livetemplate/livetemplate#344. Deploy the server update before or simultaneously with this client version.

Before assuming safe degradation, confirm what actually happens when the server receives an unrecognized __navigate__ WebSocket action on an old server version:

  • Silent no-op: best case — the action is logged/ignored, navigation is lost but the connection stays open
  • Socket close: worse — the server closes the connection, causing a reconnect flash on every same-pathname navigation until the server is upgraded
  • Error response: handled by the client's error path

If the server closes the socket, the CHANGELOG warning needs to be stronger ("do not deploy this client without also deploying livetemplate/livetemplate#344 first").

Related: livetemplate/livetemplate#344

Original Comment

Rollout sequencing
CHANGELOG notes the server must be deployed before or simultaneously with this client. Worth confirming whether the server treats an unrecognised __navigate__ action as a silent no-op or closes the socket — if the latter, a partial deploy breaks navigation rather than degrades it gracefully.


This issue was automatically created by prmonitor from PR review comments.

Metadata

Metadata

Assignees

No one assigned

    Labels

    follow-upFollow-up task from PR reviewfrom-reviewIssue originated from PR review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions