Context
This follow-up task was identified during the review of PR #94.
Source PR: #94
PR Title: feat: scroll enhancements — data-lvt-target for scroll effects, lvt-scroll-away, bottom-sticky first-run
Suggested by: @claude[bot]
Task Description
In setupFxDOMEventTriggers, resolveTarget(el) is called on every event fire (click, keydown, etc.) rather than once at setup time. Since resolveTarget is a simple querySelector/closest call, this is low-cost, but resolving at setup time would:
- Match the pattern used in
scroll-away.ts
- Avoid repeated DOM queries on high-frequency events like
mouseenter
Low priority — resolveTarget is cheap and the current approach handles dynamic DOM correctly.
This issue was automatically created by prmonitor from PR review comments.
Context
This follow-up task was identified during the review of PR #94.
Source PR: #94
PR Title: feat: scroll enhancements — data-lvt-target for scroll effects, lvt-scroll-away, bottom-sticky first-run
Suggested by: @claude[bot]
Task Description
In
setupFxDOMEventTriggers,resolveTarget(el)is called on every event fire (click, keydown, etc.) rather than once at setup time. SinceresolveTargetis a simplequerySelector/closestcall, this is low-cost, but resolving at setup time would:scroll-away.tsmouseenterLow priority —
resolveTargetis cheap and the current approach handles dynamic DOM correctly.This issue was automatically created by prmonitor from PR review comments.