-
Notifications
You must be signed in to change notification settings - Fork 0
feat: extend lvt-el: to support native DOM event triggers #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9b85553
chore(release): v0.8.17
adnaan c1dd3c9
feat: extend lvt-el: to support any native DOM event as interaction t…
adnaan 20b7c11
feat: extend lvt-fx: directives to support DOM event and lifecycle tr…
adnaan 795ffdb
fix: address bot review comments — delegation boundary, dedup, docs
adnaan d914c47
fix: eliminate duplicate directive logic — thin wrappers around apply…
adnaan 6c173c6
fix: read fx attribute value at fire time to avoid stale closure
adnaan 2be3925
fix: guard overlapping highlights, hoist regex, handle removed attrs
adnaan 58c8961
fix(ci): remove deleted graceful-shutdown example from cross-repo tests
adnaan a9bdba8
fix(ci): also remove deleted testing/01_basic from cross-repo tests
adnaan f90b250
fix: scope lifecycle listeners per wrapper, null guard, CI comment
adnaan 08c51dc
fix: teardown lifecycle listeners on disconnect, scope DOM scan to su…
adnaan d40ea28
fix: teardown delegated DOM event listeners on disconnect
adnaan 2d61d47
fix: teardown non-bubbling direct listeners, guard disconnected highl…
adnaan c2c6e8c
fix: add fx listener teardown, warn on unknown effects, hoist allList…
adnaan 89c545f
fix: prune stale element references from listener arrays on each scan
adnaan 71e6ef4
fix: clear per-element guard keys on teardown, scan root element itself
adnaan b715a8b
fix: include root in lifecycle scan, avoid allocation in event handler
adnaan b398f92
fix: avoid NodeList spread, lift NON_BUBBLING, guard inner highlight …
adnaan 03666f4
fix: restore inline styles before early return on disconnected highlight
adnaan 50b029c
fix: clear non-bubbling guard keys on lvt-el teardown
adnaan 23d373a
fix: centralize fx listener registry on wrapper, not scan root
adnaan 50fb7dd
fix: escape trigger name in delegated handler regex pattern
adnaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 0.8.16 | ||
| 0.8.17 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The v0.8.17 changelog entry doesn’t mention the new “native DOM event triggers for lvt-el:*:on:{event}” feature described in the PR, and instead references an unrelated FormData/form.name fix. Please update the entry so the changelog accurately reflects the changes being released in 0.8.17 (or move the unrelated note to the appropriate release).