-
Notifications
You must be signed in to change notification settings - Fork 0
feat(patterns): sortable list with HTML5 drag-and-drop #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8c6734c
feat(patterns): sortable list with HTML5 drag-and-drop
adnaan c75ed1f
fix(patterns): use empty-action drag bindings (marker pattern)
adnaan 5fd5944
refactor(patterns): tighten Sortable controller + trim test prose
adnaan ff7e36c
fix: address bot review on PR #84
adnaan 19d3e9e
fix: address round-2 bot review on PR #84
adnaan 479510f
fix: address round-3 bot review on PR #84
adnaan 237eef8
fix: address round-4 bot review on PR #84
adnaan 07ab9f2
fix: address round-5 bot review on PR #84
adnaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| {{define "content"}} | ||
| <article> | ||
| <hgroup> | ||
| <h3>Sortable List</h3> | ||
| <p><small>Drag any row to reorder (mouse only; no keyboard path or visual drop-zone highlighting in this demo). The new order persists across reloads. Use Reset Order to restore the initial sequence.</small></p> | ||
| </hgroup> | ||
| <p id="sortable-list-desc" class="visually-hidden">Use a mouse to drag items. Keyboard reordering is not supported in this demo.</p> | ||
| <ul id="sortable-list" | ||
| aria-label="Reorderable task list" | ||
| aria-describedby="sortable-list-desc"> | ||
| {{range .Items}} | ||
| <li data-key="{{.Key}}" | ||
| draggable="true" | ||
| lvt-on:dragstart="" | ||
| lvt-on:dragover="" | ||
| lvt-on:drop="reorder"> | ||
| <span aria-hidden="true">☰</span> {{.Name}} | ||
| </li> | ||
| {{end}} | ||
| </ul> | ||
| <form method="POST"> | ||
| <button name="reset" class="secondary outline">Reset Order</button> | ||
| </form> | ||
| </article> | ||
| {{end}} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description says TestSortable has “4 subtests” but the implementation includes 5 (Initial_Reset, Reorder_DragForward, Reorder_DragBackward, SelfDrop_NoOp, Reset_RestoresInitialOrder). Consider updating the PR description (or test) so they match.