Skip to content

FOLLOW-UP: Consider adding needs dependency for docker-build CI job (from PR #162) #164

@adnaan

Description

@adnaan

Context

This follow-up task was identified during the review of PR #162.

Source PR: #162
PR Title: ci: add Docker build job with image size validation
Suggested by: @claude[bot]

Task Description

The docker-build CI job runs in parallel with test-go and test-client. Since it rebuilds Go and the client independently inside Docker, it could show green even when unit tests are failing.

Adding needs: [test-go, test-client] would gate the Docker build on passing tests, giving a cleaner signal ("does this produce a working image from known-good code").

Trade-off

  • With needs: Cleaner CI signal, Docker only builds known-good code. Slower overall (sequential).
  • Without needs (current): Surfaces all failures at once. Docker build failure visible immediately. Faster overall (parallel).

Implementation

  docker-build:
    name: Docker Build
    needs: [test-go, test-client]
    runs-on: ubuntu-latest

This issue was automatically created by prmonitor from PR review comments.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3-lowLow: extended features, operational docsfollow-upFollow-up task from PR reviewfrom-reviewIssue originated from PR review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions