Fix BlazeRuntime injection for wrapped engines (Sentry, Flare)#102
Merged
Fix BlazeRuntime injection for wrapped engines (Sentry, Flare)#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario
The problem
Previously we used:
View::share(), which injected__blazeinto every view, causing a serialization issue in Statamic (#83).View::composer('*')with aninstanceof CompilerEnginecheck, which fixed that, but broke Sentry (#89) — which decorates the Blade engine without extending CompilerEngine, failing the check and preventing__blazefrom being injected.The solution
Replace the engine class check with a file path check:
The file extension is invariant across engine wrapping and decoration:
.blade.php— matchesBlade::render()string templates: written to{hash}.blade.php— matches.php— no match.antlers.html— no matchAdded integration tests for both the Sentry and Statamic scenarios.
Fixes #93