Handle missing compiled views during folded expiry checks#176
Open
prateekbhujel wants to merge 1 commit intolivewire:mainfrom
Open
Handle missing compiled views during folded expiry checks#176prateekbhujel wants to merge 1 commit intolivewire:mainfrom
prateekbhujel wants to merge 1 commit intolivewire:mainfrom
Conversation
Contributor
Benchmark Result: Default
Median of 10 attempts (* = outlier, excluded from result), 5000 iterations x 10 rounds, 46.61s total To run a specific benchmark, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175.
Blaze checks folded front matter after Blade reports a compiled view is fresh. If that compiled file is removed before Blaze reads it, the read can fail instead of letting Blade rebuild the view.
This retries through the compiler once when that compiled file is missing, then checks the fresh compiled output.