Fix timeline line width break when size="lg" is set on individual item#2476
Merged
calebporzio merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scenario
When using
size="lg"on an individualflux:timeline.item, the timeline line becomes thicker (2px) at that item while surrounding items remain at 1px, creating a visible break in the line.The Problem
The CSS rule
:where([data-flux-timeline-size="lg"])sets--flux-timeline-line-width: 2pxand--flux-timeline-line-gap: 0px. This selector matches any element with the attribute, including individual<li>items. When only one item hassize="lg", its line segments inherit the thicker width while surrounding items stay at 1px.The Solution
Split the CSS rule into two parts:
--flux-timeline-line-width,--flux-timeline-line-gap) and timeline-level spacing (--flux-timeline-item-gap,--flux-timeline-content-gap) now use the more specific selector:where([data-flux-timeline][data-flux-timeline-size="lg"]), which only matches the<ol>wrapper.--flux-timeline-indicator-size) remains on the broader:where([data-flux-timeline-size="lg"])selector so it can still scale per-item.Note: You will see in the fixed screenshot above the different line colours, that will be fixed in a Flux Pro PR https://github.com/livewire/flux-pro/pull/473.
Fixes #2473