Add info variant to toast component#2532
Conversation
|
i don't think an exclamation mark is the right symbol for info. i would use information-circle |
|
@hebbet First thought yes but after seeing the actual icon from website Where all icon used by toast is micro variant, this one feels too tiny and I can barely know what icon is that. However, I'm happy to change it to |
|
Thanks @ghabriel25 Looks good to me! But I would definitely go with the info icon instead. Also can you just double-check if cyan is the right color choice here? Do we have any other "info" variant of a component or anything neutral we use blue-ish color for? Just to make sure we're consistent |
|
Hi, @ganyicz I can't find any component that use Let me know about variant name whether it should be
|
|
Ugh, that's unfortunate. I don't think secondary works for the toast as there is no primary variant to begin with. The inconsistency is a bit of a turn off. Let's keep it as info, please update the screenshots in the PR with the correct icon. I'll leave it for @calebporzio to decide. |
|
Also this just made me realize, the default variant with no icon is kind of the "info" variant. Can you share how you would want to use this in your app and why isn't the default variant sufficient? |
|
For my case, I use toast variants for different message based on action. For example
All of them use session key (based on variant) which I want it consistent (using icon) |
|
@calebporzio Thanks! |


Currently, there are 3 variants for toast (success, warning, and danger) but there is no info variant for case like updating resources.
This PR adds new info variant icon to toast component
Dark mode
Light mode
The icon is from https://heroicons.com/micro and adjusted like danger variant with coloring
text-cyan-500 dark:text-cyan-400