Skip to content

Revert "Encapsulate version checking for view namespace hash"#2553

Merged
joshhanley merged 1 commit intomainfrom
revert-2551-refactor/encapsulate-version-checking
Apr 8, 2026
Merged

Revert "Encapsulate version checking for view namespace hash"#2553
joshhanley merged 1 commit intomainfrom
revert-2551-refactor/encapsulate-version-checking

Conversation

@joshhanley
Copy link
Copy Markdown
Member

Reverts #2551

This PR caused errors, so need to revert it.

Screenshot 2026-04-09 at 08 12 09AM@2x

@joshhanley joshhanley merged commit 581f33a into main Apr 8, 2026
@joshhanley joshhanley deleted the revert-2551-refactor/encapsulate-version-checking branch April 8, 2026 22:13
@ghabriel25
Copy link
Copy Markdown
Contributor

ghabriel25 commented Apr 8, 2026

@joshhanley Really sorry about that.

Thats really weird. I tested it with my local project also fresh laravel (with and without blaze) and it works as expected.

@joshhanley
Copy link
Copy Markdown
Member Author

joshhanley commented Apr 8, 2026

@ghabriel25 all good! The issue was that the Flux::getFluxViewNamespaceHash(); should have been inside the compiled string in FluxTagCompiler, not out of it. But we decided as it's such a small change that we'd revert it instead. The compiler will be quicker with the calculation happening directly rather than going through the Flux:: facade.

@ghabriel25
Copy link
Copy Markdown
Contributor

I can see the issue now. You're right, it should be at runtime not at compile time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants