[4.x] Prevent file download responses from leaking into action returns#10327
Open
joshhanley wants to merge 2 commits into
Open
[4.x] Prevent file download responses from leaking into action returns#10327joshhanley wants to merge 2 commits into
joshhanley wants to merge 2 commits into
Conversation
3 tasks
ghabriel25
reviewed
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scenario
A Livewire action can return a Laravel file download response. Livewire correctly converts the response into a
downloadeffect, but the original response object is also included in the actionreturnseffect.The Problem
SupportFileDownloadsdetectsStreamedResponseandBinaryFileResponseinstances and converts them into a JSON-safedownloadeffect.However,
HandleComponents::callMethods()still stores the original action return value ineffects.returns. For file downloads, that means a Symfony response object can leak into the final Livewire JSON payload.Returning
nullfrom the file-download hook is not enough with the current hook pipeline: component hook finish callbacks are used for side effects, and the event bus treatsnullas “keep the original forwarded value”.The Solution
After method call hooks finish, Livewire now normalises
StreamedResponseandBinaryFileResponseaction returns tonullbefore adding them toeffects.returns.The
downloadeffect remains the browser-facing instruction, and thereturnsarray keeps anullentry so action return indexes stay aligned with the submitted calls.Fixes #10326