Fixed separator bug#2
Closed
franciscocgoncalves wants to merge 2 commits intoljharb:masterfrom
franciscocgoncalves:master
Closed
Fixed separator bug#2franciscocgoncalves wants to merge 2 commits intoljharb:masterfrom franciscocgoncalves:master
franciscocgoncalves wants to merge 2 commits intoljharb:masterfrom
franciscocgoncalves:master
Conversation
Owner
Author
|
To be honest, I didn't know about this so I did a little research. This is what I found out:
Some of this information is on Wikipedia. I'm aware of the controversy of this matter and that it is required on your module, but shouldn't it be optional? If it was not only it would support all the style guides but also other languages like Portuguese. |
Owner
|
@franciscocgoncalves Fair point - I'd be open to accepting a pull request adding an option to omit the Oxford comma, despite personally feeling strongly that it should always be used :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


When reading your example I noticed that you were inserting a separator after the penultimate element of the array before the lastWord which, in my opinion, isn't appropriate for use in a sentence.
I changed it in the following way.
Behavior before fix:
Behavior after fix:
I also added a validation test that asserts two items with finalWord.