More generic image type for OCI-compliant container technologies#802
Merged
raghotham merged 3 commits intollamastack:mainfrom Jan 18, 2025
Merged
More generic image type for OCI-compliant container technologies#802raghotham merged 3 commits intollamastack:mainfrom
raghotham merged 3 commits intollamastack:mainfrom
Conversation
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
requested review from
ashwinb,
dineshyv,
dltn,
hardikjshah,
raghotham,
sixianyi0721,
vladimirivic and
yanxi0830
as code owners
facebook-github-bot
added
the
CLA Signed
raghotham
reviewed
Jan 17, 2025
Member
raghotham
left a comment
raghotham
left a comment
There was a problem hiding this comment.
seems like corresponding changes to build_container.sh are missing
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Contributor
Author
|
@raghotham Thanks! Updated. |
raghotham
approved these changes
Jan 18, 2025
Contributor
|
@terrytangyuan could you help verify that this workflow works under the change? https://github.com/meta-llama/llama-stack/actions/workflows/publish-to-docker.yml |
Contributor
Author
|
Yes, will test and let you know |
Contributor
Author
|
@yanxi0830 That workflow is currently failing. Looks like the image names have additional "-distribution" that might be unexpected. I don't think it's related to this PR though. |
Contributor
Thanks for flagging! Under my radar and will take a look. |
Contributor
Author
|
@yanxi0830 Small fix for a different issue #819 |
Contributor
Author
5 tasks
yanxi0830
added a commit
that referenced
this pull request
Jan 18, 2025
…#821) # What does this PR do? **Main Thing** - Add a simple test step before publishing docker image in workflow **Side Fix** - Docker push action fails recently due to extra prefix introduced. E.g. see: #802 (comment) cc @terrytangyuan ## Test Plan 1. Release a TestPyPi version on this code: 0.0.63.dev51206766 https://github.com/meta-llama/llama-stack/actions/runs/12841805606/job/35812033317?pr=821 ``` # 1. build docker image TEST_PYPI_VERSION=0.0.63.dev51206766 llama stack build --template fireworks # 2. test the docker image cd distributions/fireworks && docker compose up ``` 4. Test the full build + test docker flow using TestPyPi from (1): https://github.com/meta-llama/llama-stack/actions/runs/12842184947 <img width="1049" alt="image" src="https://github.com/user-attachments/assets/c025893d-5ce2-48ff-aa90-de00e105ee09" /> ## Sources Please link relevant resources if necessary. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Ran pre-commit to handle lint / formatting issues. - [ ] Read the [contributor guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md), Pull Request section? - [ ] Updated relevant documentation. - [ ] Wrote necessary unit or integration tests.
This was referenced Jan 29, 2025
ashwinb
pushed a commit
that referenced
this pull request
Jan 29, 2025
This was missed in #802 somehow.
ashwinb
pushed a commit
that referenced
this pull request
Jan 29, 2025
The current link doesn't work. Also changed docs to be consistent with #802.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a more generic term and applicable to alternatives of Docker, such as Podman or other OCI-compliant technologies.