Conversation
… was added The filesNeedingLog filter introduced with --changed-only skipped files with empty status (clean/unmodified files). For an empty string, strings.SplitSeq yields "", the len > 0 guard never fires, allNew stays true, and the file is excluded from git log — so no hash/author/message. Fix: add an explicit check for empty status (unmodified tracked file) and include those files in filesNeedingLog. Also adds TestUnmodifiedFileGetsGitInfo, an integration test that would have caught this regression. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filesNeedingLogfilter introduced with--changed-only(feat: add --changed-only/-c flag #41) inadvertently excluded unmodified tracked files (emptystatus). For an empty string,strings.SplitSeqyields"", thelen(status) > 0guard is false,allNewstaystrue, and the file is dropped from the git log query — so hash/author/message show up blank.status == ""guard that includes clean tracked files infilesNeedingLogbefore theallNewlogic runs.TestUnmodifiedFileGetsGitInfo, an integration test that creates a real repo, commits a file, runs the full filtering pipeline, and asserts the file gets its commit info populated. This test would have caught the regression.Test plan
go test ./...passesTestUnmodifiedFileGetsGitInfofails on the old code (verified by simulating the buggy filter)git lsin this repo shows commit messages again