Fix table column alignment with Unicode wide characters#29
Merged
Conversation
Tables with emoji (like ✅ and ❌) or other wide Unicode characters (CJK, etc.) were rendering with misaligned columns because the code was using character count instead of display width. The fix uses the unicode-width crate to properly calculate the display width of characters. This affects: - Table column width calculation - Table cell alignment - Text wrapping indent calculations Fixes #28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tables with emoji (like ✅ and ❌) or other wide Unicode characters (CJK, etc.) were rendering with misaligned columns because the code was using character count instead of display width.
Changes
unicode-widthcrate dependencydisplay_width()helper method that strips ANSI codes and calculates Unicode display widthBefore
After
Testing
Added unit tests to verify:
All 115 existing tests pass.
Session transcript
transcripts/29-fix-unicode-table-alignment.html
Fixes #28