setExecutionSpace thread safety#229
Closed
neelakausik wants to merge 3 commits intollnl:developfrom
Closed
Conversation
adayton1
reviewed
Jul 13, 2023
Contributor
|
Looks good to me. Was there a failing test or a something like that that prompted this change, or were you just inspecting the code for possible issues? |
dtaller
approved these changes
Jul 13, 2023
Member
@dtaller, we've been looking at launching kernels in separate GPU streams from separate CPU threads, which has led us to look into thread safety in CHAI and RAJA. This was one of the main issues that was uncovered. |
Member
|
Merged in #230 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made m_current_execution_space and m_synced_since_last_kernel thread_local to address thread safety concerns.