Skip to content

Remove optional explicit synchronizes #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidbeckingsale merged 3 commits into from
Sep 20, 2023
Merged

Remove optional explicit synchronizes #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4450b2
Remove explicit device synchronization
adayton1 Jul 12, 2023
c8af1fc
Merge branch 'develop' into feature/dayton8/rm_explicit_sync
adayton1 Aug 21, 2023
3a49d4f
Merge branch 'develop' into feature/dayton8/rm_explicit_sync
adayton1 Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions src/chai/ArrayManager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,23 +396,6 @@ class ArrayManager
*/
void disableCallbacks() { m_callbacks_active = false; }

/*!
* \brief Turn on device synchronization after every kernel.
*/
[[deprecated("Set the CUDA_LAUNCH_BLOCKING or HIP_LAUNCH_BLOCKING environment variable instead")]]
void enableDeviceSynchronize() { m_device_synchronize = true; }

/*!
* \brief Turn off device synchronization after every kernel.
*/
[[deprecated("Set the CUDA_LAUNCH_BLOCKING or HIP_LAUNCH_BLOCKING environment variable instead")]]
void disableDeviceSynchronize() { m_device_synchronize = false; }

/*!
* \brief Turn on device synchronization after every kernel.
*/
bool deviceSynchronize() { return m_device_synchronize; }

/*!
* \brief synchronize the device if there hasn't been a synchronize since the last kernel
*/
Expand Down
24 changes: 1 addition & 23 deletions src/chai/managed_ptr.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ namespace chai {
/// Be aware that CHAI checks every CUDA API call for GPU errors by default. To
/// turn off GPU error checking, pass -DCHAI_ENABLE_GPU_ERROR_CHECKING=OFF as
/// an argument to cmake when building CHAI. To turn on synchronization after
/// every kernel, call ArrayManager::getInstance()->enableDeviceSynchronize().
/// every kernel, set the appropriate environment variable (e.g. CUDA_LAUNCH_BLOCKING or HIP_LAUNCH_BLOCKING).
/// Alternatively, call cudaDeviceSynchronize() after any call to make_managed,
/// make_managed_from_factory, or managed_ptr::free, and check the return code
/// for errors. If your code crashes in the constructor/destructor of T, then
Expand Down Expand Up @@ -502,11 +502,6 @@ namespace chai {
if (pointer) {
destroy_on_device(temp);
m_gpu_pointer = nullptr;
#ifndef CHAI_DISABLE_RM
if (ArrayManager::getInstance()->deviceSynchronize()) {
synchronize();
}
#endif
}

break;
Expand Down Expand Up @@ -535,11 +530,6 @@ namespace chai {
if (pointer) {
destroy_on_device(pointer);
m_gpu_pointer = nullptr;
#ifndef CHAI_DISABLE_RM
if (ArrayManager::getInstance()->deviceSynchronize()) {
synchronize();
}
#endif
}

break;
Expand Down Expand Up @@ -964,12 +954,6 @@ namespace chai {
hipLaunchKernelGGL(detail::make_on_device, 1, 1, 0, 0, gpuBuffer, args...);
#endif

#ifndef CHAI_DISABLE_RM
if (ArrayManager::getInstance()->deviceSynchronize()) {
synchronize();
}
#endif

// Allocate space on the CPU for the pointer and copy the pointer to the CPU
T** cpuBuffer = (T**) malloc(sizeof(T*));
gpuMemcpy(cpuBuffer, gpuBuffer, sizeof(T*), gpuMemcpyDeviceToHost);
Expand Down Expand Up @@ -1025,12 +1009,6 @@ namespace chai {
hipLaunchKernelGGL(detail::make_on_device_from_factory, 1, 1, 0, 0, gpuBuffer, f, args...);
#endif

#ifndef CHAI_DISABLE_RM
if (ArrayManager::getInstance()->deviceSynchronize()) {
synchronize();
}
#endif

// Allocate space on the CPU for the pointer and copy the pointer to the CPU
T** cpuBuffer = (T**) malloc(sizeof(T*));
gpuMemcpy(cpuBuffer, gpuBuffer, sizeof(T*), gpuMemcpyDeviceToHost);
Expand Down