Merged
Conversation
Merge v2025.09.0 back into develop
adayton1
requested review from
MrBurmark,
dtaller,
liu15,
rchen20 and
robinson96
dtaller
reviewed
Sep 15, 2025
| callback(pointer_record, | ||
| ACTION_FREE, | ||
| ExecutionSpace(PINNED)); | ||
| //callback(pointer_record, |
Contributor
There was a problem hiding this comment.
Should you add an explanation of why this is commented out, and when it could be re-enabled?
Member
Author
There was a problem hiding this comment.
I'm just matching the other commented out calls. This experimental code was added by the spheral team. They were planning to add support for callbacks in the future.
dtaller
approved these changes
Sep 15, 2025
liu15
approved these changes
Sep 15, 2025
artv3
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHAI_ENABLE_EXPERIMENTALby default