Skip to content

HIP Constructor Fix#706

Merged
rchen20 merged 2 commits intodevelopfrom
fix/chen59/hipconstructor
Dec 13, 2019
Merged

HIP Constructor Fix#706
rchen20 merged 2 commits intodevelopfrom
fix/chen59/hipconstructor

Conversation

@rchen20
Copy link
Copy Markdown
Member

@rchen20 rchen20 commented Dec 13, 2019

Summary

  • This PR is a bugfix.
  • It does the following (modify list as needed):
    • Fixes build failure of nvcc10+gcc7.3.1. Compiler was unable to modify ValueLoc operator= with RAJA_HOST_DEVICE. Now, uses default constructors for nvcc > 9.2 and HIP.
    • Adds HIP build script for Corona.

Copy link
Copy Markdown
Member

@davidbeckingsale davidbeckingsale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @rchen20 !

@rchen20 rchen20 requested a review from mdavis36 December 13, 2019 21:41
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 13, 2019

Codecov Report

Merging #706 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #706   +/-   ##
=========================================
  Coverage   98.683%   98.683%           
=========================================
  Files           70        70           
  Lines         1291      1291           
=========================================
  Hits          1274      1274           
  Misses          17        17
Impacted Files Coverage Δ
include/RAJA/pattern/detail/reduce.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b704af0...89b99b2. Read the comment docs.

@rchen20 rchen20 merged commit c05355f into develop Dec 13, 2019
@rchen20 rchen20 deleted the fix/chen59/hipconstructor branch December 13, 2019 23:44
Copy link
Copy Markdown
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants