-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
- As far as I can tell, we're only building/installing the package but we're not running the unit tests during CI.
- In addition, the CI checks on PRs appear to be blocked (waiting approval).
- Finally, we seems to be deploying the documentation from any branch and not just the main branch.
To Reproduce
Steps to reproduce the behavior:
- open a PR that breaks some unit tests
- notice that checks don't run (waiting for approval)
- assuming checks ran and passed, notice that you're not blocked from merging
- notice that the docs have been deployed from your branch before you even merged
I haven't actually reproduced the issue beyond step 2 but I noticed that:
- Unit tests are broken on
main - The CI action doesn't seem to run any of the unit tests. There is a coverage step but it's silently failing:
Expected behavior
All the PR checks (build/install, lint, docs, unit tests) should run on push and probably block merge until they pass.
Output
See inline screenshots.
Desktop (please complete the following information):
NA
Additional context
None
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working