Skip to content

Unit tests aren't running in CI #5

@igoumiri

Description

@igoumiri

Describe the bug

  • As far as I can tell, we're only building/installing the package but we're not running the unit tests during CI.
  • In addition, the CI checks on PRs appear to be blocked (waiting approval).
    waiting approval
  • Finally, we seems to be deploying the documentation from any branch and not just the main branch.

To Reproduce
Steps to reproduce the behavior:

  1. open a PR that breaks some unit tests
  2. notice that checks don't run (waiting for approval)
  3. assuming checks ran and passed, notice that you're not blocked from merging
  4. notice that the docs have been deployed from your branch before you even merged

I haven't actually reproduced the issue beyond step 2 but I noticed that:

  1. Unit tests are broken on main
  2. The CI action doesn't seem to run any of the unit tests. There is a coverage step but it's silently failing:
    failing coverage step

Expected behavior
All the PR checks (build/install, lint, docs, unit tests) should run on push and probably block merge until they pass.

Output
See inline screenshots.

Desktop (please complete the following information):
NA

Additional context
None

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions