Skip to content

Spurious testing false positives on randomly-generated names #181

@rountree

Description

@rountree

bool parseOpen(int proc, char *filename, int ret_code)

In src/logging/spindle_logd.cc:265, parseOpen() compares filename against several patterns, including bin. During testing for another issue, mpich generated a temporary file named /dev/shm/mpich_shar_tmptUBbin, which matched the test for bin, causing a spurious failure.

Replace the bin string with /bin caused a more reliable failure:

28567 [Client.0.47@lookup_libc.c:110] get_libc - Looking for libc: is it /home/spindleuser/Spindle-build/testsuite/libtest18.so?
28568 Error: Didn't load target: bin on proc 11[Client.0.47@lookup_libc.c:110] get_libc - Looking for libc: is it /home/spindleuser/Spindle-build/testsuite/libtest19.so?
28569
28570 [Client.0.47@lookup_libc.c:110] get_libc - Looking for libc: is it /home/spindleuser/Spindle-build/testsuite/libtest20.so?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions