Add support for AMD GPUs#20
Merged
davidbeckingsale merged 46 commits intodevelopfrom Nov 20, 2018
Merged
Conversation
This allows the ROCM and CUDA code to be more easily shared, without having long logical defined(X) || defined(Y) checks.
…memory-resource-traits
Codecov Report
@@ Coverage Diff @@
## develop #20 +/- ##
===========================================
- Coverage 79.38% 79.29% -0.09%
===========================================
Files 43 43
Lines 621 628 +7
===========================================
+ Hits 493 498 +5
- Misses 128 130 +2
Continue to review full report at Codecov.
|
mcfadden8
reviewed
Nov 20, 2018
| set(UMPIRE_ENABLE_SLIC ${ENABLE_SLIC}) | ||
| set(UMPIRE_ENABLE_ASSERTS ${ENABLE_ASSERTS}) | ||
| set(UMPIRE_ENABLE_STATISTICS ${ENABLE_STATISTICS}) | ||
| set(UMPIRE_ENABLE_ROCM ${ENABLE_ROCM}) |
Collaborator
There was a problem hiding this comment.
Did a description of this new option get added to https://github.com/LLNL/Umpire/blob/develop/docs/sphinx/advanced_configuration.rst?
Member
Author
There was a problem hiding this comment.
Nope 😞 I'll do that!
Collaborator
|
Other than my comment on documentation, this looks great! |
Member
Author
|
@mcfadden8 - I updated the docs. |
mcfadden8
approved these changes
Nov 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.