Remove unused CMake variable AXOM_ENABLE_CORE

[bmhan12]

This PR:

• Removes unused CMake variable AXOM_ENABLE_CORE

This variable was noticed by @johnbowen42 while testing Axom builds.
The variable is only defined here and not used anywhere else in the CMake build.
The variable is only mentioned here and not anywhere else in the CMake build.

[white238]

The point of that was to error if someone tried to turn off Core. It wasnt creating the variable.

[johnbowen42]

The point of that was to error if someone tried to turn off Core. It wasnt creating the variable.

I tried to manually enable core and hit this error. Maybe we could keep the variable but only error if somebody actually turns it off?

[white238]

Here is where it is not created:

axom/src/cmake/AxomMacros.cmake

Lines 102 to 106 in 4b274b0

	if(NOT "${COMPONENT_NAME_LOWERED}" STREQUAL "core")
	option(AXOM_ENABLE_${COMPONENT_NAME_CAPITALIZED}
	"Enables ${arg_COMPONENT_NAME}"
	${arg_DEFAULT_STATE})
	endif()

We could change the check to see if it is defined and set to OFF, but we should not removed the error check.

[johnbowen42]

Here is where it is not created:

axom/src/cmake/AxomMacros.cmake

Lines 102 to 106 in 4b274b0

	if(NOT "${COMPONENT_NAME_LOWERED}" STREQUAL "core")
	option(AXOM_ENABLE_${COMPONENT_NAME_CAPITALIZED}
	"Enables ${arg_COMPONENT_NAME}"
	${arg_DEFAULT_STATE})
	endif()

We could change the check to see if it is defined and set to OFF, but we should not removed the error check.

that's what I was thinking

[white238]

Update if to include allowing users to set it to ON, though mildly pointless. Dont remove helpful error message.

[rhornung67]

Update if to include allowing users to set it to ON, though mildly pointless. Dont remove helpful error message.

Pointless, yes. But some people may find it cathartic.... 😄

[bmhan12]

Update if to include allowing users to set it to ON, though mildly pointless. Dont remove helpful error message.

Gotcha, adjusted.

[kennyweiss]

Seems like a reasonable change.
I'll echo @white238's comments that core cannot be disabled, but I suppose it's harmless to manually enable it