Skip to content

Add cmake option for CAMP_USE_PLATFORM_DEFAULT_STREAM#205

Open
helloworld922 wants to merge 5 commits into
llnl:mainfrom
helloworld922:feature/default_stream
Open

Add cmake option for CAMP_USE_PLATFORM_DEFAULT_STREAM#205
helloworld922 wants to merge 5 commits into
llnl:mainfrom
helloworld922:feature/default_stream

Conversation

@helloworld922

Copy link
Copy Markdown

No description provided.

Riyaz Haque and others added 2 commits May 29, 2026 10:57
Changes to the cmake option for default stream
Comment thread CMakeLists.txt Outdated

option(CAMP_USE_PLATFORM_DEFAULT_STREAM "Whether CAMP should use the default device streams (On) or create separate streams (Off)" Off)

set(CAMP_USE_PLATFORM_DEFAULT_STREAM_NUM 0)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: should set this to OFF and ON. If you use cmakedefine01, CMake will also set it to 0 and 1 respectively w/o having the additional @CAMP_USE_PLATFORM_DEFAULT_STREAM_NUM@. If that is really needed as opposed to just having it defined in preprocessor.

https://cmake.org/cmake/help/latest/command/configure_file.html#transformations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants