Skip to content

Fix for MemoryAccess in SYCL resource.#77

Merged
trws merged 2 commits intollnl:masterfrom
rchen20:bugfix/chen59/syclma
Aug 16, 2021
Merged

Fix for MemoryAccess in SYCL resource.#77
trws merged 2 commits intollnl:masterfrom
rchen20:bugfix/chen59/syclma

Conversation

@rchen20
Copy link
Member

@rchen20 rchen20 commented Aug 16, 2021

No description provided.

@rchen20
Copy link
Member Author

rchen20 commented Aug 16, 2021

@trws @rhornung67 This ought to fix the compilation error in the SYCL PR. The MemoryAccess variable was just missing from some function signatures.

@rchen20
Copy link
Member Author

rchen20 commented Aug 16, 2021

Just made another change to fix the error regarding conversion from void * to char*. @trws should edit this fix if there is something wrong with using the SYCL templated mallocs.

@trws
Copy link
Member

trws commented Aug 16, 2021

There shouldn't be, this looks really good, thanks for the fix @rchen20!

@trws trws merged commit db41e04 into llnl:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants