Skip to content

Remove explicit SHARED from add_library#17

Merged
hariharan-devarajan merged 1 commit into
llnl:developfrom
izzet:fix-library-type
Sep 29, 2024
Merged

Remove explicit SHARED from add_library#17
hariharan-devarajan merged 1 commit into
llnl:developfrom
izzet:fix-library-type

Conversation

@izzet
Copy link
Copy Markdown
Contributor

@izzet izzet commented Sep 29, 2024

  1. The CMakeLists.txt already sets BUILD_SHARED_LIBS to ON by default.
  2. Removing the explicit SHARED specification allows users to control library type (shared or static).

The library will still be built as SHARED by default, but now offers the option to be built as STATIC if needed.

Copy link
Copy Markdown
Member

@hariharan-devarajan hariharan-devarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.

@hariharan-devarajan hariharan-devarajan merged commit 9c5d29e into llnl:develop Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants