Skip to content

Fix cmake variable name mismatches#27

Merged
hariharan-devarajan merged 2 commits into
llnl:developfrom
JaeseungYeom:cmake_fix
Jun 4, 2026
Merged

Fix cmake variable name mismatches#27
hariharan-devarajan merged 2 commits into
llnl:developfrom
JaeseungYeom:cmake_fix

Conversation

@JaeseungYeom

Copy link
Copy Markdown
Contributor
  • There are a number of places where non-existent library path variable names are used.
  • CMAKE_INSTALL_LIBDIR was used in place of CPP_LOGGER_LIBDIR
  • CPP_LOGGER_LIBDIR does not contain CMAKE_INSTALL_PREFIX. So, it needs to be added for library path definition
  • CMAKE_INSTALL_BINDIR is only valid with a cmake option CPP_LOGGER_LIBDIR_AS_LIB=ON.
  • Set properties of exported target
  • There is no variable as CMAKE_INSTALL_DIR. It is replaced with @CPP_LOGGER_LIBDIR@/cmake/cpp-logger

@hariharan-devarajan hariharan-devarajan merged commit 9c05a17 into llnl:develop Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants