Fix cmake variable name mismatches#27
Merged
Merged
Conversation
JaeseungYeom
commented
May 24, 2026
Contributor
- There are a number of places where non-existent library path variable names are used.
- CMAKE_INSTALL_LIBDIR was used in place of CPP_LOGGER_LIBDIR
- CPP_LOGGER_LIBDIR does not contain CMAKE_INSTALL_PREFIX. So, it needs to be added for library path definition
- CMAKE_INSTALL_BINDIR is only valid with a cmake option CPP_LOGGER_LIBDIR_AS_LIB=ON.
- Set properties of exported target
- There is no variable as CMAKE_INSTALL_DIR. It is replaced with @CPP_LOGGER_LIBDIR@/cmake/cpp-logger
hariharan-devarajan
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.