Dapper-Python NormalizedFileName modification #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alized name for string representation (#69)
nightlark
force-pushed
the
dapper-python-update
branch
from
3929728 to
c80a723
Compare
nightlark
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
NormalizedFileNameclass into a dataclass to reduce some boilerplate and add additional builtin functionality of dataclasses (automatic repr, etc)Adds
__str__to return the name to make it simpler to get the normalized filename.If a user just wants the normalized name but doesn't care to check the other info, they can now use
str(normalize_file_name(file))and will return the name string regardless of whethernormalize_file_namereturns a string or instance ofNormalizedFileName