Checkpoint/02 02 26 by hariharan-devarajan · Pull Request #169 · llnl/datacrumbs

hariharan-devarajan · 2026-02-02T21:57:11Z

No description provided.

1. Enhance argument parsing and logging, add UTF-8 character removal, and update dependency handling 2. Tested Lustre configurations 3. Improved validation case to handle all cases 4. reduced logging to avoid blowing up log files

1. Generalized scheduler implementation to be updated by any user. 2. Specialized implementation for prolog and epilog script for slurm and flux and general.

…xisting probes from JSON

1. Build instructions 2. Required dependencies 3. Deployment options

milroy · 2026-02-05T19:15:11Z

        get_filename_component(json-c_INCLUDE_DIR "${json-c_DIR}/../../../include" ABSOLUTE)
        get_filename_component(json-c_LIBRARY_DIR "${json-c_DIR}/../../" ABSOLUTE)
-        include_directories(json-c::json-c)
+        include_directories(${json-c_INCLUDE_DIR})


Investigate JSON-C package config.

I tried across different version on different os version, this is very unreliable. I will keep it like this for now.

milroy · 2026-02-05T19:41:12Z

+
+  std::cout << "\n";
+  std::cout << "╔════════════════════════════════════════════════════════════════════════════╗\n";
+  std::cout << "║                     INVALID PROBES BY CATEGORY                            ║\n";


Suggested change

std::cout << "║ INVALID PROBES BY CATEGORY ║\n";

std::cout << "║ INVALID PROBES BY CATEGORY ║\n";

milroy · 2026-02-05T19:48:06Z

+   match-leak-kinds: definite,indirect
+   ...
+   fun:pthread_*
+}


Made it here 2/5/2026.

milroy · 2026-02-12T19:58:42Z

+    if (DATACRUMBS_SCHEDULER_JOBID_ENV_VAR STREQUAL "NONE")
+        if(DATACRUMBS_SCHEDULER_TYPE STREQUAL "SLURM")
+            set(DATACRUMBS_SCHEDULER_JOBID_ENV_VAR "SLURM_JOB_ID")
+        elseif(DATACRUMBS_SCHEDULER_TYPE STREQUAL "OPENMPI")


Consider DATACRUMBS_LAUNCHER_TYPE.

milroy · 2026-02-12T20:06:38Z

+fi
+
+info "salloc ${DATACRUMBS_ARGS[*]}"
+exec salloc "${DATACRUMBS_ARGS[@]}"


Made it here 2/12

milroy · 2026-03-05T19:39:35Z

-    readonly DATACRUMBS_USER
+fi
+
+if [[ "${DATACRUMBS_ENV_LOADED:-0}" == "0" ]]; then


Need to keep readonly here.

Suggested change

if [[ "${DATACRUMBS_ENV_LOADED:-0}" == "0" ]]; then

readonly DATACRUMBS_IS_ROOT

readonly DATACRUMBS_USER

fi

if [[ "${DATACRUMBS_ENV_LOADED:-0}" == "0" ]]; then

Looks like readonly is still missing in the script.

Correction: I now see readonly is present in the final changes. GitHub wasn't rendering all the changes due to the large changeset.

milroy · 2026-03-05T19:49:51Z

+file(MAKE_DIRECTORY ${CMAKE_DATA_OUTPUT_DIRECTORY})

 if(_DATACRUMBS_DATA_FILES)
    install(FILES ${_DATACRUMBS_DATA_FILES}


Completed this commit on 3/5/2026

milroy

Looks good! Approving this PR.

- Formatting on probe_validator.cpp - Change DATACRUMBS_SCHEDULER_TYPE -> DATACRUMBS_LAUNCHER_TYPE - Make DATACRUMBS_IS_ROOT and DATACRUMBS_USER readonly

milroy

After confirming the changes, I can re-approve the PR. Sorry for the delay.

milroy · 2026-04-13T22:32:11Z

-    readonly DATACRUMBS_USER
+fi
+
+if [[ "${DATACRUMBS_ENV_LOADED:-0}" == "0" ]]; then


Correction: I now see readonly is present in the final changes. GitHub wasn't rendering all the changes due to the large changeset.

hariharan-devarajan requested a review from a team as a code owner February 2, 2026 21:57

hariharan-devarajan force-pushed the checkpoint/02-02-26-new branch 9 times, most recently from 3c471ae to 44b0ed7 Compare February 3, 2026 02:00

hariharan-devarajan added 4 commits February 2, 2026 18:07

feat: arg parsing improvements and lustre configurations

bc94649

1. Enhance argument parsing and logging, add UTF-8 character removal, and update dependency handling 2. Tested Lustre configurations 3. Improved validation case to handle all cases 4. reduced logging to avoid blowing up log files

Added slurm integration

e847bfc

1. Generalized scheduler implementation to be updated by any user. 2. Specialized implementation for prolog and epilog script for slurm and flux and general.

Enhance probe management by adding enable_explorer flag and loading e…

d84bb57

…xisting probes from JSON

added initial docs

078a19c

1. Build instructions 2. Required dependencies 3. Deployment options

hariharan-devarajan force-pushed the checkpoint/02-02-26-new branch from 44b0ed7 to f2f4d17 Compare February 3, 2026 02:09

add linting for sh and cmake files.

f6a8428

hariharan-devarajan force-pushed the checkpoint/02-02-26-new branch from f2f4d17 to f6a8428 Compare February 3, 2026 06:04

hariharan-devarajan requested a review from milroy February 3, 2026 06:07

milroy reviewed Feb 5, 2026

View reviewed changes

milroy reviewed Feb 12, 2026

View reviewed changes

milroy reviewed Mar 5, 2026

View reviewed changes

milroy approved these changes Apr 2, 2026

View reviewed changes

hariharan-devarajan force-pushed the checkpoint/02-02-26-new branch from af202ed to f6a8428 Compare April 2, 2026 18:29

Fixed PR Changes

e8211c2

- Formatting on probe_validator.cpp - Change DATACRUMBS_SCHEDULER_TYPE -> DATACRUMBS_LAUNCHER_TYPE - Make DATACRUMBS_IS_ROOT and DATACRUMBS_USER readonly

hariharan-devarajan force-pushed the checkpoint/02-02-26-new branch from af202ed to e8211c2 Compare April 7, 2026 20:44

milroy approved these changes Apr 13, 2026

View reviewed changes

hariharan-devarajan merged commit 95cf42a into develop Apr 13, 2026
5 checks passed

	std::cout << "║ INVALID PROBES BY CATEGORY ║\n";
	std::cout << "║ INVALID PROBES BY CATEGORY ║\n";

Conversation

hariharan-devarajan commented Feb 2, 2026

Uh oh!

milroy Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

milroy left a comment

Choose a reason for hiding this comment

Uh oh!

milroy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

milroy Feb 5, 2026 •

edited

Loading