Skip to content

Enhance: Add offset handling in DFTracerAnalyzer#19

Merged
izzet merged 2 commits intollnl:mainfrom
izzet:enhance/dftracer-keep-offset
Aug 2, 2025
Merged

Enhance: Add offset handling in DFTracerAnalyzer#19
izzet merged 2 commits intollnl:mainfrom
izzet:enhance/dftracer-keep-offset

Conversation

@izzet
Copy link
Collaborator

@izzet izzet commented Aug 2, 2025

This pull request introduces changes to improve data type handling and extend functionality for processing I/O traces in the dfanalyzer module. The most important changes include adjustments to column data types, the addition of a new offset column, and updates to ensure proper handling of the offset field in I/O trace processing.

Data type adjustments:

  • Updated the integer column data type in fix_dtypes to use Int64 instead of Int32 for consistency with other integer columns (dfanalyzer/analysis_utils.py, dfanalyzer/analysis_utils.pyL36-R36).

Enhancements to I/O trace processing:

  • Added a new offset column to the schema returned by io_columns to capture offset information (dfanalyzer/dftracer.py, dfanalyzer/dftracer.pyR195).
  • Updated io_function to extract and include the offset field from json_dict arguments if present and valid (dfanalyzer/dftracer.py, dfanalyzer/dftracer.pyR216-R219).
  • Modified postread_trace to replace zero values in the offset column with NaN for better handling of missing data (dfanalyzer/dftracer.py, dfanalyzer/dftracer.pyR700).

@izzet izzet requested a review from Copilot August 2, 2025 03:43
@izzet izzet self-assigned this Aug 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the DFTracerAnalyzer to improve data type handling and add offset tracking capabilities for I/O trace processing. The changes focus on standardizing integer data types and extending the schema to capture offset information from I/O operations.

  • Updated integer column data type from Int32 to Int64 for consistency across the codebase
  • Added offset column to the I/O trace schema to capture file position information
  • Enhanced I/O function processing to extract and handle offset values from trace data

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
dfanalyzer/analysis_utils.py Changed integer column data type from Int32 to Int64 for consistency
dfanalyzer/dftracer.py Added offset column to schema, enhanced I/O function to extract offset values, and updated postread processing to handle zero offset values

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@izzet izzet merged commit 68e5297 into llnl:main Aug 2, 2025
2 of 3 checks passed
@izzet izzet deleted the enhance/dftracer-keep-offset branch November 26, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants