Disable openmp when raja is not used #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronrutherford
approved these changes
Oct 21, 2022
| endif() | ||
|
|
||
| if(NOT (HIOP_USE_GPU AND HIOP_USE_HIP)) | ||
| if(HIOP_USE_RAJA AND (NOT (HIOP_USE_GPU AND HIOP_USE_HIP))) |
Collaborator
There was a problem hiding this comment.
Agreed that this closes the xSDK issue, however, we should update in future to fix this based on our discussion.
Collaborator
Author
There was a problem hiding this comment.
I agree! I saw you have already created an issue for it (#563)
Collaborator
|
It would be great if we could tag another minor release to have xSDK builds passing on mac |
6 tasks
Collaborator
will prepare tag 0.7.1 sometime before Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix xsdk-project/xsdk-issues#181