Skip to content

Update IPM NLP solvers to be aware of weighted spaces #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cnpetra merged 45 commits into from
Sep 3, 2025
Merged

Update IPM NLP solvers to be aware of weighted spaces #710

cnpetra merged 45 commits into from
Sep 3, 2025

Conversation

@cnpetra
Copy link
Collaborator

@cnpetra cnpetra commented Mar 3, 2025 •
edited
Loading

This PR contains partial instrumentation of quasi-Newton solver with weighted spaces (discretized Hilbert spaces) for primal variables.

Merging it as WIP because it contains a couple of fixes

  • termination criteria of Krylov iterative refinement
  • improved logging for fixed variables, relaxed variables, and relax bounds
  • user manual update for derivative checker
  • some wrong logic in triggering feasibility restoration

@cnpetra cnpetra marked this pull request as draft March 3, 2025 23:08
cnpetra added 26 commits March 5, 2025 10:55
@cnpetra
wrapper for WeiInProd wrapper in NlpFormulation
14a243c
@cnpetra
draft of InnerProd class
89bc337
@cnpetra
cleaning up
a1ae282
@cnpetra
temp code + notes
826c5d2
@cnpetra
added additional functionality for residual norm (weighted)
46c055f
@cnpetra
IPM alg nlp errors
1caeb33
@cnpetra
clean up, fixed warnings
e4edea2
@cnpetra
addressed MPI issues
cab209f
@cnpetra
exposing mass matrix in the example
bf79f0d
@cnpetra
added volume and lumped matrix
5887c75
@cnpetra
adding weights through the code (linear system and resids)
f0de791
@cnpetra
weighted log barrier reduce/sum
67f98d9
@cnpetra
log bar weighting functionality in Iterate
df028e9
@cnpetra
fixing ci runtime errors
a44d355
@cnpetra
cuda and raja impl; also added tests
82c02d6
@cnpetra
fixed bug in test and syntax for thrust::transform
758ee13
@cnpetra
fixed typo in Raja Vec Impl
ecb7554
@cnpetra
fixing logBarWeighted in RAJA vector
fc2b25d
@cnpetra
stregthen test for logBarrierWeighted
86c437e
@cnpetra
HIP implementation logBarrierWeight
038229f
@cnpetra
draft of weighted B0 in the LowRank quasi Newton solves
01495bf
@cnpetra
fixed bug in new B0 code
b283b07
@cnpetra
duals lsq computation
1d54e3f
@cnpetra
draft of Hessian approx - code works mesh independently
63d8f88
@cnpetra
added test for Ex1 with L2
3295382
@cnpetra
M lumped applies in residuals
57a3067
@cnpetra cnpetra changed the title Update IPM NLP solvers to be aware of finite element spaces Update IPM NLP solvers to be aware of weighted spaces Mar 23, 2025
@cnpetra cnpetra requested a review from nychiang August 18, 2025 19:58
@cnpetra cnpetra marked this pull request as ready for review August 18, 2025 19:59
@cnpetra cnpetra mentioned this pull request Aug 27, 2025
Open
8 tasks
nychiang
nychiang approved these changes Sep 3, 2025
View reviewed changes
Copy link
Collaborator

@nychiang nychiang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just suggested some minor changes

@cnpetra cnpetra merged commit 2b08f83 into develop Sep 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nychiang nychiang nychiang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cnpetra @nychiang