add test tree for lustre 2.10.8/zfs #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add /sys and /proc content to lustre_versions Add expected 2.10.8 output files for all tests Adjust test driver to detect version >= 2.10 and not attempt to dump brw stats that no longer exist. Fixes llnl#46 Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Contributor
Author
|
|
morrone
reviewed
Dec 3, 2019
Member
morrone
left a comment
morrone
left a comment
There was a problem hiding this comment.
I'm not really familiar with that part of the code. If it works for you, that'ss good enough for me.
Contributor
Author
OK, fair enough. Thank you. |
tonyhutter
approved these changes
Dec 3, 2019
tonyhutter
left a comment
tonyhutter
left a comment
There was a problem hiding this comment.
Yea, I'm also unfamiliar with this code. It looks relatively harmless, so approved.
Contributor
Author
|
Mostly Harmless wins the day. Thanks! |
Contributor
Author
|
Merged as
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add /sys and /proc content to lustre_versions
Add expected 2.10.8 output files for all tests
Adjust test driver to detect version >= 2.10 and
not attempt to dump brw stats that no longer
exist.
Fixes #46
Testing:
Ran make check