Changes needed to enable Python interfaces - second iteration#795
Merged
Changes needed to enable Python interfaces - second iteration#795
Conversation
balos1
requested review from
cswoodward,
drreynolds and
gardner48
as code owners
gardner48
requested changes
Nov 11, 2025
Member
gardner48
left a comment
gardner48
left a comment
There was a problem hiding this comment.
Finished a pass over everything exclude include.
gardner48
requested changes
Nov 14, 2025
Member
gardner48
left a comment
gardner48
left a comment
There was a problem hiding this comment.
Finished a pass over include
Collaborator
Steven-Roberts
left a comment
Steven-Roberts
left a comment
There was a problem hiding this comment.
The GitHub UI is bugging out for me, I'll submit this partial review and see if I can get my comments showing again in the code. Ignore the include/sundials/sundials_classview.hpp comments for now.
Collaborator
Steven-Roberts
left a comment
Steven-Roberts
left a comment
There was a problem hiding this comment.
Rest of the review
Steven-Roberts
requested changes
Nov 18, 2025
gardner48
requested changes
Nov 19, 2025
Member
gardner48
left a comment
gardner48
left a comment
There was a problem hiding this comment.
A few doc items, otherwise this looks good to me
Co-authored-by: David Gardner <gardner48@llnl.gov>
Steven-Roberts
approved these changes
Nov 21, 2025
gardner48
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the content was already reviewed in PR #768. However, quite a bit changed and I think its actually a smaller diff to just target develop again.