Fix quadrature initialization in IDAS#888
Draft
Steven-Roberts wants to merge 3 commits intodevelopfrom
Draft
Conversation
Contributor
|
Thank you, @Steven-Roberts, for tracing this issue down and identifying the root cause. This has been showing up in GridKit tests nondeterministically. See here, for example. Changes in simulation configuration would make these issues come and go. |
pelesh
reviewed
Mar 24, 2026
Contributor
pelesh
left a comment
There was a problem hiding this comment.
I ran preliminary tests and this fix seems to address the issue we were seeing in GridKit. I need to run more tests to confirm.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When IDAS takes its first time step, it calls the quadrature RHS' to fill in
ida_phiQ[1]andida_phiQS[1]vectors. When IDAS is reinitialized, it does not do this due to some logic errors. This caused a couple issues