Skip to content

Conversation

@michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Mar 6, 2024

Summary

Currently if a unification operation results in a duplicate index in the perfdata multi-index, users will hit an error during the _fill_perfdata function. By moving the validation check before this function, which checks for duplicates, we can provide a clearer error message, which results in faster debugging for us and the user.

Example

New

For cases without metadata_key

DuplicateIndexError: Duplicate index {798655681} found in DataFrame index.

For cases with metadata_key

DuplicateValueError: Different Thicket.metadata[metadata_key] may not contain duplicate values.
thickets[0].metadata['tuning'] and thickets[1].metadata['tuning'] have the same values: [{'block_128'}]

Old

ValueError: cannot handle a non-unique multi-index!

@michaelmckinsey1 michaelmckinsey1 added area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-blocked PR is temporarily blocked from merge type-feature Requests for new features or PRs which implement new features labels Mar 6, 2024
@michaelmckinsey1
Copy link
Collaborator Author

michaelmckinsey1 commented Mar 6, 2024

Depends on #125 unit test data

@michaelmckinsey1 michaelmckinsey1 added status-ready-for-review This PR is ready to be reviewed by assigned reviewers and removed status-blocked PR is temporarily blocked from merge labels Mar 12, 2024
@michaelmckinsey1 michaelmckinsey1 force-pushed the feature-precheck_thicket branch from 578c8cb to 653919b Compare March 12, 2024 19:00
@michaelmckinsey1 michaelmckinsey1 changed the title Improve Validation Checks to Avoid Confusion Improve Validation Checks Mar 22, 2024
@michaelmckinsey1 michaelmckinsey1 force-pushed the feature-precheck_thicket branch from f4da505 to c95f585 Compare April 8, 2024 20:15
@slabasan slabasan merged commit 292135c into llnl:develop Apr 8, 2024
@michaelmckinsey1 michaelmckinsey1 deleted the feature-precheck_thicket branch April 9, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants