-
Notifications
You must be signed in to change notification settings - Fork 9
Improve Validation Checks #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
slabasan
merged 11 commits into
llnl:develop
from
michaelmckinsey1:feature-precheck_thicket
Apr 8, 2024
Merged
Improve Validation Checks #142
slabasan
merged 11 commits into
llnl:develop
from
michaelmckinsey1:feature-precheck_thicket
Apr 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
|
578c8cb to
653919b
Compare
f4da505 to
c95f585
Compare
slabasan
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-thicket
Issues and PRs involving Thicket's core Thicket datastructure and associated classes
priority-normal
Normal priority issues and PRs
status-ready-for-review
This PR is ready to be reviewed by assigned reviewers
type-feature
Requests for new features or PRs which implement new features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently if a unification operation results in a duplicate index in the perfdata multi-index, users will hit an error during the
_fill_perfdatafunction. By moving the validation check before this function, which checks for duplicates, we can provide a clearer error message, which results in faster debugging for us and the user.Example
New
For cases without metadata_key
For cases with metadata_key
Old