Fix intersection #193
Merged
Fix intersection #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Fixes #186 |
michaelmckinsey1
force-pushed
the
fix-intersection
branch
from
e4603a1 to
c99ec68
Compare
michaelmckinsey1
added
area-thicket
ilumsden
added
status-approved
pearce8
approved these changes
Jul 11, 2024
Yejashi
pushed a commit
to TauferLab/thicket
that referenced
this pull request
Sep 4, 2024
* Fix intersection * Fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the intersection function when Thicket was created using
_fill_perfdata=False.Add separate query for when the perfdata is not padded as checking the name column for
Nonevalues will not work. Additionally, the new query that checks the length of per-node slices of the perfdata will not work when the perfdata is padded, so both queries are necessary.