Fix Bug in add_ncu #196
Merged
Fix Bug in add_ncu #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmckinsey1
added
area-thicket
ilumsden
requested changes
Jul 22, 2024
Collaborator
ilumsden
left a comment
ilumsden
left a comment
There was a problem hiding this comment.
The revised logic for dupe_cols looks good, but there's a pretty major issue in handling chosen_metrics that could easily break NCUReader if not addressed.
| @@ -602,6 +593,15 @@ def _rep_agg_func(col): | |||
| if chosen_metrics: | |||
| ncu_df = ncu_df[chosen_metrics] | |||
Collaborator
There was a problem hiding this comment.
You need to have a type check before doing this. Since you don't validate the type of chosen_metrics anywhere, you could get an input that would cause various parts of the rest of the code to error. Off the top of my head, some scenarios are:
- Passing a number (e.g.,
int,float) would cause this line to fail with aKeyErroriff there is not a column with an integer or float index - Passing a string would cause this line to succeed, but it would also return a
Seriesinstead of aDataFrame. This would cause all the code following this line to fail.
ilumsden
added
status-approved
Collaborator
|
@michaelmckinsey1 Can you please resolve conflicts on this PR? Apologies if I merged these in the wrong order. |
michaelmckinsey1
force-pushed
the
fix-ncu_check
branch
from
b7cc225 to
23d57ad
Compare
michaelmckinsey1
added
status-revisions-needed
added 2 commits
October 25, 2024 11:28
michaelmckinsey1
added
status-approved
slabasan
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#178 Introduced a bug when
chosen_metricswas not provided. Whenchosen_metrics=Noneall ncu metrics are added to the perf dataframe. This PR fixes the bug by modifying the check and moving it, where we can check for duplicate columns whenchosen_metrics=Noneaswell.chosen_metricsbefore reading NCUchosen_metricsisNonewe will know which metrics are present.