Only Print Duplicates in Error Message #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmckinsey1
added
area-utils
Collaborator
|
@michaelmckinsey1 Are you able to amend this PR to check for duplicates earlier? Can we update the error message to report collisions to us? |
slabasan
approved these changes
Feb 13, 2025
Collaborator
slabasan
left a comment
slabasan
left a comment
There was a problem hiding this comment.
I can't recall my note about checking for this "earlier", so merging this now and will revisit if it comes up again.
Collaborator
Author
I think we only discussed it verbally, but for the future: from what I remember I would basically need to restructure the validation checks to check earlier and add an additional check for hash collisions, which is on my todo list. This PR is strictly improving the way the existing check works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the error message in develop, it is hard to tell which index is the duplicate when there are many profiles. In this example the duplicate is
3723623787.develop
This PR
