Fancy new algorithm on stable SIMD and a bunch of other stuff#44
Merged
llogiq merged 1 commit intollogiq:masterfrom Oct 24, 2018
Merged
Fancy new algorithm on stable SIMD and a bunch of other stuff#44llogiq merged 1 commit intollogiq:masterfrom
llogiq merged 1 commit intollogiq:masterfrom
Conversation
b9035f4 to
bd6f528
Compare
Owner
|
What's with the appveyor build? |
mati865
reviewed
Aug 27, 2018
| @@ -0,0 +1,161 @@ | |||
| use std::arch::x86_64::{ | |||
There was a problem hiding this comment.
You have to import x86 module for i686 systems.
Collaborator
Author
Collaborator
Author
|
Fix is up. Sorry for the wait (^_^;). |
Owner
|
Thanks! I'll prepare a new release shortly. |
Collaborator
Author
|
I'll need to update the README since the flags have changed; give me 24h and I'll have a PR. Might also make sense to have a limited beta or somesuch since there's a lot of fresh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sigh. I'm not a fan of Rust's fragmentation around SIMD. Let's see, we have
packed_simd,Why? Well,
no_std,naive_operations.If the generic version supported stable, we could throw out 2. and 4., and I could make 1. a simple extension, like it used to be. It might make sense to just throw some of this out now for maintainability reasons; this clearly isn't a sane way of doing things.
Good luck reviewing this ¬_¬. Did I mention it's all
unsafe?