Featrue remove execute tool calls stream#1
Merged
Conversation
…ool_calls_stream - Move tool execution from post-stream execute_tool_calls_stream() into the TOOL_CALL case inside the stream parsing loop - Replace conv_add_tool_results + build_tool_results_content_json with per-tool conv_add_single_tool_result calls - Replace session_log_tool_results with inline collection via tool_conv_results variable - Simplify case $stop to only handle fatal stop reasons (error/max_tokens/length) - All other stop reasons handled uniformly in post-case if/else block - Update ARCHITECTURE.md: remove stale execute_tool_calls() references Net: +53/-109 lines, 46/46 tests pass
- Bash: replace conv_add_single_tool_result loop with batch conv_add_tool_results call - Go: inline tool dispatch into SSE callback, remove executeToolCalls (~48 lines) - Rust: inline tool dispatch into SSE callback, remove execute_tool_calls (~56 lines) - Align stop-reason logic across all three: fatal stops (error/max_tokens/length) exit immediately before conv write; interrupt check guards persistence; compact after conv write; continue loop only for tool_use/tool_calls - Add ARCHITECTURE.port-alignment.md documenting completed alignment state - All three versions compile/check successfully - Zero stale references to removed functions in source code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.