Add ConstString initializer to ArrayType #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanhaskins
approved these changes
Sep 19, 2017
Member
harlanhaskins
left a comment
harlanhaskins
left a comment
There was a problem hiding this comment.
LGTM mod the comment nit
|
|
||
| /// Creates a constant array value of i8 from a swift string. | ||
| /// | ||
| /// - parameter string: A string to create a null terminated array from. |
Member
There was a problem hiding this comment.
Can you be explicit about this being the UTF-8 bytes of the string?
Contributor
Author
There was a problem hiding this comment.
Creates a constant, null terminated array value of utf8 bytes from string's utf8 member.
Good?
Member
There was a problem hiding this comment.
Use “UTF-8” for the first one and surround the 2nd utf8 in code voice and we’re good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an initializer to create a constant string using
It wraps
LLVMConstStringInContext