Allow customization of message shown if tests pass #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like https://swiftenv.fuller.li/install.sh is down. |
regnerjr
reviewed
Apr 19, 2018
Sources/LiteSupport/TestRunner.swift
Outdated
| pathExtensions: Set<String>, testLinePrefix: String, | ||
| parallelismLevel: ParallelismLevel) throws { | ||
| parallelismLevel: ParallelismLevel, | ||
| successMessage: String = "All tests passed! 🎉") throws { |
There was a problem hiding this comment.
This is nice!
I think the default here can be removed, since it’s passed in from Run.swift line 39
There was a problem hiding this comment.
Good idea. I've removed the default in TestRunner.
If all the tests of a lite instance pass, the string passed as the `successMessage` parameter of `runLite` will be displayed. A default message is displayed if no success message is specified.
|
@franklinsch This patch LGTM. Despite the missing script this passes on macOS and I have no doubt it will pass on Linux as well. Will give this patch until midnight my time and merge then regardless of CI status |
|
@CodaFi Looks like the swiftenv script is working again. |
|
⛵ thank you @franklinsch!! |
|
@harlanhaskins Could we make a release for this patch? So that I can import it using SwiftPM |
|
Tagged 0.0.10! |
|
That was fast, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
A
successMessageparameter is added torunLite, which provides the ability to customize the message shown if all the tests pass.The default message "All tests pass! 🎉" displayed if no success message is specified.
The message is shown in bold green.
What's worth discussing about this pull request?
Should the user be able to customize the color and boldness as well?
What downsides are there to merging this pull request?
🤷🏻♂️